Fix: bounding box undefined causing white screen of death#1416
Conversation
There was a problem hiding this comment.
I ran prettier on this file, nothing changed
|
*Lighthouse ran on https://mobility-feeds-dev--pr-1416-6os259oi.web.app/ * (Desktop)
*Lighthouse ran on https://mobility-feeds-dev--pr-1416-6os259oi.web.app/feeds * (Desktop)
*Lighthouse ran on https://mobility-feeds-dev--pr-1416-6os259oi.web.app/feeds/gtfs/mdb-2126 * (Desktop)
*Lighthouse ran on https://mobility-feeds-dev--pr-1416-6os259oi.web.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
*Lighthouse ran on https://mobility-feeds-dev--pr-1416-6os259oi.web.app/gbfs/gbfs-flamingo_porirua * (Desktop)
|
|
Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-1416-6os259oi.web.app |
Alessandro100
force-pushed
the
fix/1414-bounding-box-undefined
branch
from
01f8f59 to
9601190
Compare
davidgamez
left a comment
davidgamez
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for the quick fix 🥇
2 participants
Summary:
closes #1414
When the feed has bounding box undefined, it would crash the page
Expected behavior:
If the bounding box is undefined, it will not display the map and instead show an error
Testing tips:
Find a feed with bounding box undefined (eg; /feeds/gtfs/mdb-1100) and see in the console that there are no errors in regards to bounding box / bounds or lat long
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything